From 213b53ed355712b97d361a273a87f1162b8b7aab Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Fri, 28 Oct 2022 12:24:31 +0200 Subject: [PATCH] Revert "Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir'" This reverts commit 7589034cc3151bfac8cc3d3af5e91402a78e160b. The previous commit 14816de9af69 ("Cygwin: spawn: drop special handling for cmd.exe and command.com") make this patch unnecessary. The filename argument (i. e., run_path in the caller) is now always non-NULL. Signed-off-by: Corinna Vinschen --- winsup/cygwin/spawn.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc index a450ea443..f0ae73999 100644 --- a/winsup/cygwin/spawn.cc +++ b/winsup/cygwin/spawn.cc @@ -215,8 +215,6 @@ handle (int fd, bool writing) static bool is_console_app (WCHAR *filename) { - if (filename == NULL) - return true; /* The command executed is command.com or cmd.exe. */ HANDLE h; const int id_offset = 92; h = CreateFileW (filename, GENERIC_READ, FILE_SHARE_READ,