From 33c7b2b544a96ee443728f9558ce07a13e05f1e8 Mon Sep 17 00:00:00 2001 From: Joel Sherrill Date: Wed, 15 Mar 2017 12:04:22 -0500 Subject: [PATCH] libc/string/strsignal.c: Use of || not && lead to dead code. Coverity Id: 175333 --- newlib/libc/string/strsignal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/newlib/libc/string/strsignal.c b/newlib/libc/string/strsignal.c index 94ae26db1..e32c9a7be 100644 --- a/newlib/libc/string/strsignal.c +++ b/newlib/libc/string/strsignal.c @@ -37,7 +37,7 @@ QUICKREF /* * Written by Joel Sherrill . * - * COPYRIGHT (c) 2010. + * COPYRIGHT (c) 2010, 2017. * On-Line Applications Research Corporation (OAR). * * Permission to use, copy, modify, and distribute this software for any @@ -49,8 +49,6 @@ QUICKREF * WARRANTY. IN PARTICULAR, THE AUTHOR MAKES NO REPRESENTATION * OR WARRANTY OF ANY KIND CONCERNING THE MERCHANTABILITY OF THIS * SOFTWARE OR ITS FITNESS FOR ANY PARTICULAR PURPOSE. - * - * $Id$ */ #include @@ -72,7 +70,7 @@ _DEFUN (strsignal, (signal), buffer = _REENT_SIGNAL_BUF(ptr); #if defined(SIGRTMIN) && defined(SIGRTMAX) - if ((signal >= SIGRTMIN) || (signal <= SIGRTMAX)) { + if ((signal >= SIGRTMIN) && (signal <= SIGRTMAX)) { siprintf (buffer, "Real-time signal %d", signal - SIGRTMIN); return buffer; }