drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cygwin: pty: Fix crash on master close in Windows 7. 

- The 4th parameter of WriteFile() cannot be NULL especially in
  Windows 7 as mentioned in Microsoft documentation. This patch
  fixes that.

Addresses: https://cygwin.com/pipermail/cygwin/2022-March/251162.html
This commit is contained in:
Takashi Yano 2022-03-30 12:46:08 +09:00
parent be9c0561e7
commit 49a00a0673
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
winsup/cygwin/fhandler_tty.cc
View File

@ -2106,7 +2106,7 @@ fhandler_pty_master::close ()
} }
release_output_mutex (); release_output_mutex ();
get_ttyp ()->stop_fwd_thread = true; get_ttyp ()->stop_fwd_thread = true;
WriteFile (to_master_nat, "", 0, NULL, NULL); WriteFile (to_master_nat, "", 0, &len, NULL);
master_fwd_thread->detach (); master_fwd_thread->detach ();
} }
} }

3
winsup/cygwin/release/3.3.5
View File

@ -43,3 +43,6 @@ Bug Fixes
- Fix a formatting problem in gmondump where all displayed addresses are - Fix a formatting problem in gmondump where all displayed addresses are
mistakenly prefixed with "0x0x". mistakenly prefixed with "0x0x".
- Fix crash on pty master close in Windows 7.
Addresses: https://cygwin.com/pipermail/cygwin/2022-March/251162.html