From 532ecdd36f37e4c5985b8a7c992324e5df48f7a1 Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Mon, 27 Jun 2016 18:00:01 +0200 Subject: [PATCH] Add comment to point out missing access right per documentation In get_mem_values we open the process without PROCESS_VM_READ access and are *still* able to request working set information, despite MSDN claiming we need it for this purpose. Instead of adding this access right, just add an comment to point this out for now. Signed-off-by: Corinna Vinschen --- winsup/cygwin/fhandler_process.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/winsup/cygwin/fhandler_process.cc b/winsup/cygwin/fhandler_process.cc index 9730fa768..216f095c9 100644 --- a/winsup/cygwin/fhandler_process.cc +++ b/winsup/cygwin/fhandler_process.cc @@ -1436,6 +1436,10 @@ get_mem_values (DWORD dwProcessId, unsigned long *vmsize, unsigned long *vmrss, PMEMORY_WORKING_SET_LIST p; SIZE_T n = 0x4000, length; + /* This appears to work despite MSDN claiming that QueryWorkingSSet requires + PROCESS_QUERY_INFORMATION *and* PROCESS_VM_READ. Since we're trying to do + everything with least perms, we stick to PROCESS_QUERY_INFORMATION only + unless this changes in Windows for some reason. */ hProcess = OpenProcess (PROCESS_QUERY_INFORMATION, FALSE, dwProcessId); if (hProcess == NULL) {