drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* thread.cc (pthread_cond::Broadcast): Don't print error messages on invalid 

mutexs - user programs are allowed to call pthread_cond_broadcast like that.
(__pthread_cond_timedwait): Initialise themutex properly.
(__pthread_cond_wait): Initialise themutex properly.
This commit is contained in:
Christopher Faylor 2001-06-07 19:55:06 +00:00
parent 5a2f66ab43
commit 5691881058
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,11 @@
Thu Jun 7 15:54:32 2001 Robert Collins <rbtcollins@hotmail.com>
* thread.cc (pthread_cond::Broadcast): Don't print error messages on
invalid mutexs - user programs are allowed to call
pthread_cond_broadcast like that.
(__pthread_cond_timedwait): Initialise themutex properly.
(__pthread_cond_wait): Initialise themutex properly.
Tue Jun 5 19:56:00 2001 Corinna Vinschen <corinna@vinschen.de> Tue Jun 5 19:56:00 2001 Corinna Vinschen <corinna@vinschen.de>
* fhandler_console.cc (fhandler_console::dup): Allocate space for * fhandler_console.cc (fhandler_console::dup): Allocate space for

7
winsup/cygwin/thread.cc
View File

@ -424,7 +424,10 @@ pthread_cond::BroadCast ()
{ {
if (pthread_mutex_unlock (&cond_access)) if (pthread_mutex_unlock (&cond_access))
system_printf ("Failed to unlock condition variable access mutex, this %0p\n", this); system_printf ("Failed to unlock condition variable access mutex, this %0p\n", this);
/* This isn't and API error - users are allowed to call this when no threads
are waiting
system_printf ("Broadcast called with invalid mutex\n"); system_printf ("Broadcast called with invalid mutex\n");
*/
return; return;
} }
while (count--) while (count--)
@ -1639,6 +1642,8 @@ __pthread_cond_timedwait (pthread_cond_t * cond, pthread_mutex_t * mutex,
if ((((pshared_mutex *)(mutex))->flags & SYS_BASE == SYS_BASE)) if ((((pshared_mutex *)(mutex))->flags & SYS_BASE == SYS_BASE))
// a pshared mutex // a pshared mutex
themutex = __pthread_mutex_getpshared (mutex); themutex = __pthread_mutex_getpshared (mutex);
else
themutex = mutex;
if (!verifyable_object_isvalid (*themutex, PTHREAD_MUTEX_MAGIC)) if (!verifyable_object_isvalid (*themutex, PTHREAD_MUTEX_MAGIC))
return EINVAL; return EINVAL;
@ -1685,6 +1690,8 @@ __pthread_cond_wait (pthread_cond_t * cond, pthread_mutex_t * mutex)
if ((((pshared_mutex *)(mutex))->flags & SYS_BASE == SYS_BASE)) if ((((pshared_mutex *)(mutex))->flags & SYS_BASE == SYS_BASE))
// a pshared mutex // a pshared mutex
themutex = __pthread_mutex_getpshared (mutex); themutex = __pthread_mutex_getpshared (mutex);
else
themutex = mutex;
if (!verifyable_object_isvalid (*themutex, PTHREAD_MUTEX_MAGIC)) if (!verifyable_object_isvalid (*themutex, PTHREAD_MUTEX_MAGIC))
return EINVAL; return EINVAL;
if (!verifyable_object_isvalid (*cond, PTHREAD_COND_MAGIC)) if (!verifyable_object_isvalid (*cond, PTHREAD_COND_MAGIC))