drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cygwin: unlink: don't try "final trick" in try_to_bin on NFS 

Doesn't work.  Just another STATUS_SHARING_VIOLATION.

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2017-10-18 16:22:14 +02:00
parent e6c79e7a2a
commit 5b7921523d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/syscalls.cc
View File

@ -532,8 +532,8 @@ try_to_bin (path_conv &pc, HANDLE &fh, ACCESS_MASK access, ULONG flags)
NtClose (fh);
fh = NULL; /* So unlink_nt doesn't close the handle twice. */
/* On success or when trying to unlink a directory we just return here.
The below code only works for files. */
if (NT_SUCCESS (status) || pc.isdir ())
The below code only works for files. It also fails on NFS. */
if (NT_SUCCESS (status) || pc.isdir () || pc.fs_is_nfs ())
goto out;
/* The final trick. We create a temporary file with delete-on-close
semantic and rename that file to the file just moved to the bin.