From 7589034cc3151bfac8cc3d3af5e91402a78e160b Mon Sep 17 00:00:00 2001 From: Takashi Yano Date: Sat, 22 Oct 2022 14:05:40 +0900 Subject: [PATCH] Cygwin: pty: Fix 'Bad address' error when running 'cmd.exe /c dir' - If the command executed is 'cmd.exe /c [...]', runpath in spawn.cc will be NULL. In this case, is_console_app(runpath) check causes access violation. This case also the command executed is obviously console app., therefore, treat it as console app to fix this issue. Addresses: https://github.com/msys2/msys2-runtime/issues/108 --- winsup/cygwin/spawn.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc index 5aa52ab1e..4fc842a2b 100644 --- a/winsup/cygwin/spawn.cc +++ b/winsup/cygwin/spawn.cc @@ -215,6 +215,8 @@ handle (int fd, bool writing) static bool is_console_app (WCHAR *filename) { + if (filename == NULL) + return true; /* The command executed is command.com or cmd.exe. */ HANDLE h; const int id_offset = 92; h = CreateFileW (filename, GENERIC_READ, FILE_SHARE_READ,