drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix incorrect implementation to clear per-thread pending signals 

* sigproc.cc (class pending_signals): Drop sigproc_init friendship.
	(pending_signals::clear): Fix implementation to avoid subsequent
	endless loop in wait_sig.  Improve comment.

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2015-11-02 13:53:25 +01:00
parent df6206aa56
commit 90b9303f0b
2 changed files with 17 additions and 5 deletions
winsup/cygwin
ChangeLogsigproc.cc

6
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,9 @@
2015-11-02 Corinna Vinschen <corinna@vinschen.de>
* sigproc.cc (class pending_signals): Drop sigproc_init friendship.
(pending_signals::clear): Fix implementation to avoid subsequent
endless loop in wait_sig. Improve comment.
2015-11-02 Corinna Vinschen <corinna@vinschen.de> 2015-11-02 Corinna Vinschen <corinna@vinschen.de>
* mount.h (enum fs_info_type): Add prlfs (Parallels Desktop FS). * mount.h (enum fs_info_type): Add prlfs (Parallels Desktop FS).

16
winsup/cygwin/sigproc.cc
View File

@ -82,7 +82,6 @@ public:
void clear (_cygtls *tls); void clear (_cygtls *tls);
friend void __reg1 sig_dispatch_pending (bool); friend void __reg1 sig_dispatch_pending (bool);
friend void WINAPI wait_sig (VOID *arg); friend void WINAPI wait_sig (VOID *arg);
friend void sigproc_init ();
}; };
Static pending_signals sigq; Static pending_signals sigq;
@ -398,14 +397,21 @@ sig_clear (int sig)
sigq.clear (sig); sigq.clear (sig);
} }
/* Clear pending signals of specific thread. Called from /* Clear pending signals of specific thread. Called under TLS lock from
_cygtls::remove_pending_sigs. */ _cygtls::remove_pending_sigs. */
void void
pending_signals::clear (_cygtls *tls) pending_signals::clear (_cygtls *tls)
{ {
for (int sig = 0; sig < NSIG + 1; ++sig) sigpacket *q = &start, *qnext;
if (sigs[sig].sigtls == tls)
clear (sig); while ((qnext = q->next))
{
if (qnext->sigtls == tls)
{
q->next = qnext->next;
qnext->si.si_signo = 0;
}
}
} }
/* Clear pending signals of specific thread. Called from _cygtls::remove */ /* Clear pending signals of specific thread. Called from _cygtls::remove */