drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cygwin: fstatat: call fstat64 instead of fstat 

This fixes a bug on 32-bit Cygwin that was introduced in commit
84252946, "Cygwin: fstatat, fchownat: support the AT_EMPTY_PATH flag".

Add a comment explaining why fstat should not be called.

Addresses: https://cygwin.com/pipermail/cygwin/2021-January/247399.html
This commit is contained in:
Ken Brown 2021-01-12 14:18:28 -05:00
parent a485393aea
commit 9ad86f619c
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
winsup/cygwin/release/3.2.0
View File

@ -42,3 +42,6 @@ Bug Fixes
- Fix return value of sqrtl on negative infinity. - Fix return value of sqrtl on negative infinity.
Addresses: https://cygwin.com/pipermail/cygwin/2020-October/246606.html Addresses: https://cygwin.com/pipermail/cygwin/2020-October/246606.html
- Fix a bug in fstatat(2) on 32 bit that could cause it to return garbage.
Addresses: https://cygwin.com/pipermail/cygwin/2021-January/247399.html

5
winsup/cygwin/syscalls.cc
View File

@ -1929,6 +1929,9 @@ _fstat64_r (struct _reent *ptr, int fd, struct stat *buf)
} }
#ifdef __i386__ #ifdef __i386__
/* This entry point is retained only to serve old 32 bit applications
built under Cygwin 1.3.x or earlier. Newer 32 bit apps are redirected
to fstat64; see NEW_FUNCTIONS in Makefile.in. */
extern "C" int extern "C" int
fstat (int fd, struct stat *buf) fstat (int fd, struct stat *buf)
{ {
@ -4852,7 +4855,7 @@ fstatat (int dirfd, const char *__restrict pathname, struct stat *__restrict st,
cwdstuff::cwd_lock.release (); cwdstuff::cwd_lock.release ();
} }
else else
return fstat (dirfd, st); return fstat64 (dirfd, st);
} }
path_conv pc (path, ((flags & AT_SYMLINK_NOFOLLOW) path_conv pc (path, ((flags & AT_SYMLINK_NOFOLLOW)
? PC_SYM_NOFOLLOW : PC_SYM_FOLLOW) ? PC_SYM_NOFOLLOW : PC_SYM_FOLLOW)