From a7a5d0ba3742911e0ab9dfeed077631f25bb257f Mon Sep 17 00:00:00 2001 From: Christopher Faylor Date: Mon, 14 Oct 2002 02:37:49 +0000 Subject: [PATCH] * cygthread.cc (cygthread::stub): Don't zero __name here. That introduces a race. --- winsup/cygwin/ChangeLog | 5 +++++ winsup/cygwin/cygthread.cc | 21 +++++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index df2e66ba6..8eb5d9367 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,8 @@ +2002-10-13 Christopher Faylor + + * cygthread.cc (cygthread::stub): Don't zero __name here. That + introduces a race. + 2002-10-13 Christopher Faylor * include/cygwin/version.h: Bump DLL minor number. diff --git a/winsup/cygwin/cygthread.cc b/winsup/cygwin/cygthread.cc index ec217b792..ce64a746c 100644 --- a/winsup/cygwin/cygthread.cc +++ b/winsup/cygwin/cygthread.cc @@ -44,21 +44,26 @@ cygthread::stub (VOID *arg) } while (1) { - if (!info->func || initialized < 0) - ExitThread (0); + if (!info->__name) + system_printf ("errnoneous thread activation"); + else + { + if (!info->func || initialized < 0) + ExitThread (0); - /* Cygwin threads should not call ExitThread directly */ - info->func (info->arg == cygself ? info : info->arg); - /* ...so the above should always return */ + /* Cygwin threads should not call ExitThread directly */ + info->func (info->arg == cygself ? info : info->arg); + /* ...so the above should always return */ #ifdef DEBUGGING - info->func = NULL; // catch erroneous activation + info->func = NULL; // catch erroneous activation #endif - SetEvent (info->ev); - info->__name = NULL; + SetEvent (info->ev); + } switch (WaitForSingleObject (info->thread_sync, INFINITE)) { case WAIT_OBJECT_0: + // ResetEvent (info->thread_sync); continue; default: api_fatal ("WFSO failed, %E");