drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused and unsafe call to __builtin_frame_address 

initial_sp has been unused since commit fbf23e3 back in 2000.
Keep the value, so as to avoid changing the offset of magic_biscuit.

winsup/cygwin/lib/_cygwin_crt0_common.cc:140:52:
error: calling 'void* __builtin_frame_address(unsigned int)' with a
nonzero argument is unsafe [-Werror=frame-address]
   u->initial_sp = (char *) __builtin_frame_address (1);

winsup/cygwin/ChangeLog
lib/_cygwin_crt0_common.cc (_cygwin_crt0_common): Initialize initial_sp
with nullptr.

Signed-off-by: Peter Foley <pefoley2@pefoley.com>
This commit is contained in:
Peter Foley 2016-03-19 13:45:47 -04:00 committed by Corinna Vinschen
parent 3df400dc83
commit c0b6fc54b1
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
winsup/cygwin/lib/_cygwin_crt0_common.cc
View File

@ -135,9 +135,8 @@ _cygwin_crt0_common (MainFunc f, per_process *u)
u->premain[3] = cygwin_premain3; u->premain[3] = cygwin_premain3;
u->fmode_ptr = &_fmode; u->fmode_ptr = &_fmode;
/* This is used to record what the initial sp was. The value is needed /* Unused */
when copying the parent's stack to the child during a fork. */ u->initial_sp = NULL;
u->initial_sp = (char *) __builtin_frame_address (1);
/* Remember whatever the user linked his application with - or /* Remember whatever the user linked his application with - or
point to entries in the dll. */ point to entries in the dll. */