drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* spawn.cc (spawn_guts): Define sec_attribs and call sec_user_nih() only once.

This commit is contained in:
Christopher Faylor 2002-06-11 02:22:02 +00:00
parent 380aaf2d2c
commit d5377829a8
2 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,8 @@
2002-06-09 Pierre Humblet <pierre.humblet@ieee.org>
* spawn.cc (spawn_guts): Define sec_attribs and call sec_user_nih()
only once.
2002-06-10 Christopher Faylor <cgf@redhat.com> 2002-06-10 Christopher Faylor <cgf@redhat.com>
* Makefile.in: Ensure that -MD gets added to CFLAGS regardless of * Makefile.in: Ensure that -MD gets added to CFLAGS regardless of

20
winsup/cygwin/spawn.cc
View File

@ -623,7 +623,7 @@ spawn_guts (const char * prog_arg, const char *const *argv,
cygbench ("spawn-guts"); cygbench ("spawn-guts");
if (!cygheap->user.impersonated || cygheap->user.token == INVALID_HANDLE_VALUE) if (!cygheap->user.impersonated || cygheap->user.token == INVALID_HANDLE_VALUE)
{ {
PSECURITY_ATTRIBUTES sec_attribs = sec_user_nih (sa_buf);
ciresrv.moreinfo->uid = getuid32 (); ciresrv.moreinfo->uid = getuid32 ();
/* FIXME: This leaks a handle in the CreateProcessAsUser case since the /* FIXME: This leaks a handle in the CreateProcessAsUser case since the
child process doesn't know about cygwin_mount_h. */ child process doesn't know about cygwin_mount_h. */
@ -631,14 +631,12 @@ spawn_guts (const char * prog_arg, const char *const *argv,
newheap = cygheap_setup_for_child (&ciresrv, cygheap->fdtab.need_fixup_before ()); newheap = cygheap_setup_for_child (&ciresrv, cygheap->fdtab.need_fixup_before ());
rc = CreateProcess (runpath, /* image name - with full path */ rc = CreateProcess (runpath, /* image name - with full path */
one_line.buf, /* what was passed to exec */ one_line.buf, /* what was passed to exec */
/* process security attrs */ sec_attribs, /* process security attrs */
sec_user_nih (sa_buf), sec_attribs, /* thread security attrs */
/* thread security attrs */ TRUE, /* inherit handles from parent */
sec_user_nih (sa_buf),
TRUE, /* inherit handles from parent */
flags, flags,
envblock,/* environment */ envblock, /* environment */
0, /* use current drive/directory */ 0, /* use current drive/directory */
&si, &si,
&pi); &pi);
} }
@ -688,10 +686,10 @@ spawn_guts (const char * prog_arg, const char *const *argv,
one_line.buf, /* what was passed to exec */ one_line.buf, /* what was passed to exec */
sec_attribs, /* process security attrs */ sec_attribs, /* process security attrs */
sec_attribs, /* thread security attrs */ sec_attribs, /* thread security attrs */
TRUE, /* inherit handles from parent */ TRUE, /* inherit handles from parent */
flags, flags,
envblock,/* environment */ envblock, /* environment */
0, /* use current drive/directory */ 0, /* use current drive/directory */
&si, &si,
&pi); &pi);
/* Restore impersonation. In case of _P_OVERLAY this isn't /* Restore impersonation. In case of _P_OVERLAY this isn't