drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

upstream OpenBSD: arc4random: replace abort() with _exit() 

In the incredibly unbelievable circumstance where _rs_init() fails to
allocate pages, don't call abort() because of corefile data leakage
concerns, but simply _exit(). The reasoning is _rs_init() will only fail
if someone finds a way to apply specific pressure against this failure
point, for the purpose of leaking information into a core which they can
read. We don't need a corefile in this instance to debug that. So take
this "lever" away from whoever in the future wants to do that.
This commit is contained in:
deraadt 2019-03-24 17:56:54 +00:00 committed by Corinna Vinschen
parent dd22053fee
commit db5e07368c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
newlib/libc/stdlib/arc4random.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: arc4random.c,v 1.54 2015/09/13 08:31:47 guenther Exp $ */ /* $OpenBSD: arc4random.c,v 1.55 2019/03/24 17:56:54 deraadt Exp $ */
/* /*
* Copyright (c) 1996, David Mazieres <dm@uun.org> * Copyright (c) 1996, David Mazieres <dm@uun.org>
@ -75,7 +75,7 @@ _rs_init(u_char *buf, size_t n)
if (rs == NULL) { if (rs == NULL) {
if (_rs_allocate(&rs, &rsx) == -1) if (_rs_allocate(&rs, &rsx) == -1)
abort(); _exit(1);
} }
chacha_keysetup(&rsx->rs_chacha, buf, KEYSZ * 8, 0); chacha_keysetup(&rsx->rs_chacha, buf, KEYSZ * 8, 0);