drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid SEGV when handling SIDs with 0 subauthorities 

* sec_helper.cc (cygsid::get_sid): Don't reject SIDs with missing
	subauthorities.

Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
This commit is contained in:
Corinna Vinschen 2015-10-22 15:38:42 +02:00
parent 6599fad55d
commit e01381afde
3 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
winsup/cygwin/ChangeLog
View File

@ -1,3 +1,8 @@
2015-10-22 Corinna Vinschen <corinna@vinschen.de>
* sec_helper.cc (cygsid::get_sid): Don't reject SIDs with missing
subauthorities.
2015-10-22 Corinna Vinschen <corinna@vinschen.de> 2015-10-22 Corinna Vinschen <corinna@vinschen.de>
* strfuncs.cc (sys_cp_wcstombs): Always return number of multibytes * strfuncs.cc (sys_cp_wcstombs): Always return number of multibytes

3
winsup/cygwin/release/2.3.0
View File

@ -43,3 +43,6 @@ Bug Fixes
- Fix memory leak in calls to pthread_getattr_np. - Fix memory leak in calls to pthread_getattr_np.
- Fix output of /proc/<PID>/winexename. - Fix output of /proc/<PID>/winexename.
- Avoid SEGV when handling SIDs with 0 subauthorities.
Addresses: https://cygwin.com/ml/cygwin/2015-10/msg00141.html

5
winsup/cygwin/sec_helper.cc
View File

@ -218,7 +218,10 @@ cygsid::get_sid (DWORD s, DWORD cnt, DWORD *r, bool well_known)
SID_IDENTIFIER_AUTHORITY sid_auth = { SECURITY_NULL_SID_AUTHORITY }; SID_IDENTIFIER_AUTHORITY sid_auth = { SECURITY_NULL_SID_AUTHORITY };
# define SECURITY_NT_AUTH 5 # define SECURITY_NT_AUTH 5
if (s > 255 || cnt < 1 || cnt > SID_MAX_SUB_AUTHORITIES) /* 2015-10-22: Note that we let slip SIDs with a subauthority count of 0.
There are systems, which generate the SID S-1-0 as group ownership SID,
see https://cygwin.com/ml/cygwin/2015-10/msg00141.html. */
if (s > 255 || cnt > SID_MAX_SUB_AUTHORITIES)
{ {
psid = NO_SID; psid = NO_SID;
return NULL; return NULL;