drew
/
acadia-newlib
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Cygwin: fhandler_base: Fix double free caused when open() fails. 

- When open fails, archetype stored in archetypes[] is not cleared.
  This causes double free when next open fail. This patch fixes the
  issue.

Addresses:
  https://cygwin.com/pipermail/cygwin/2022-January/250518.html
This commit is contained in:
Takashi Yano 2022-01-18 22:17:37 +09:00
parent 0cae2b802b
commit ff539cc0f9
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
winsup/cygwin/fhandler.cc
View File

@ -440,8 +440,8 @@ fhandler_base::open_with_arch (int flags, mode_t mode)
if (!(res = (archetype && archetype->io_handle) if (!(res = (archetype && archetype->io_handle)
|| open (flags, mode & 07777))) || open (flags, mode & 07777)))
{ {
if (archetype) if (archetype && archetype->usecount == 0)
delete archetype; cygheap->fdtab.delete_archetype (archetype);
} }
else if (archetype) else if (archetype)
{ {

3
winsup/cygwin/release/3.3.4
View File

@ -30,3 +30,6 @@ Bug Fixes
- Fix a problem creating a dir "foo", if a file (but not a Cygwin symlink) - Fix a problem creating a dir "foo", if a file (but not a Cygwin symlink)
"foo.lnk" already exists. "foo.lnk" already exists.
Addresses: https://github.com/msys2/msys2-runtime/issues/81 Addresses: https://github.com/msys2/msys2-runtime/issues/81
- Fix double free for archetype, which is caused when open() fails.
Addresses: https://cygwin.com/pipermail/cygwin/2022-January/250518.html