drew
/
acadia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

[zion] Begin requiring capability transmit permission. 

As a first pass require the permission when passing a capability to a
new process.
This commit is contained in:
Drew Galbraith 2023-08-01 18:37:17 -07:00
parent f0a27d30be
commit 4e9ad6a516
3 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
zion/object/port.h
View File

@ -22,7 +22,8 @@ class Port : public IpcObject {
public: public:
uint64_t TypeTag() override { return KernelObject::PORT; } uint64_t TypeTag() override { return KernelObject::PORT; }
static uint64_t DefaultPermissions() { static uint64_t DefaultPermissions() {
return kZionPerm_Write | kZionPerm_Read | kZionPerm_Duplicate; return kZionPerm_Write | kZionPerm_Read | kZionPerm_Duplicate |
kZionPerm_Transmit;
} }
Port() = default; Port() = default;

3
zion/syscall/memory_object.cpp
View File

@ -39,6 +39,7 @@ z_err_t MemoryObjectDuplicate(ZMemoryObjectDuplicateReq* req) {
ASSIGN_OR_RETURN( ASSIGN_OR_RETURN(
glcr::RefPtr<MemoryObject> new_vmmo, glcr::RefPtr<MemoryObject> new_vmmo,
vmmo_cap->obj<MemoryObject>()->Duplicate(req->base_offset, req->length)); vmmo_cap->obj<MemoryObject>()->Duplicate(req->base_offset, req->length));
*req->new_vmmo_cap = curr_proc.AddNewCapability(new_vmmo); *req->new_vmmo_cap =
curr_proc.AddNewCapability(new_vmmo, vmmo_cap->permissions());
return glcr::OK; return glcr::OK;
} }

9
zion/syscall/process.cpp
View File

@ -26,12 +26,15 @@ z_err_t ProcessSpawn(ZProcessSpawnReq* req) {
*req->new_vmas_cap = curr_proc.AddNewCapability(proc->vmas()); *req->new_vmas_cap = curr_proc.AddNewCapability(proc->vmas());
if (req->bootstrap_cap != 0) { if (req->bootstrap_cap != 0) {
auto cap = curr_proc.ReleaseCapability(req->bootstrap_cap); auto cap = curr_proc.GetCapability(req->bootstrap_cap);
if (!cap) { if (!cap) {
return glcr::CAP_NOT_FOUND; return glcr::CAP_NOT_FOUND;
} }
// FIXME: Check permissions. if (!(cap->HasPermissions(kZionPerm_Transmit))) {
*req->new_bootstrap_cap = proc->AddExistingCapability(cap); return glcr::CAP_PERMISSION_DENIED;
}
*req->new_bootstrap_cap = proc->AddExistingCapability(
curr_proc.ReleaseCapability(req->bootstrap_cap));
} }
return glcr::OK; return glcr::OK;