Add pid/tid to all log messages

This commit is contained in:
Drew Galbraith 2023-05-30 23:22:29 -07:00
parent 2eefda6114
commit 9e3df0ccd0
4 changed files with 27 additions and 9 deletions

View File

@ -1,6 +1,7 @@
#include "debug/debug.h" #include "debug/debug.h"
#include "common/port.h" #include "common/port.h"
#include "scheduler/scheduler.h"
#define COM1 0x3f8 #define COM1 0x3f8
@ -73,7 +74,14 @@ void MemToStr(uint64_t u, char* str) {
str[18] = '\0'; str[18] = '\0';
} }
void dbgln_internal(const char* fmt, va_list args) { void AddProcPrefix() {
if (gScheduler != nullptr) {
auto& t = gScheduler->CurrentThread();
dbg("[%u.%u] ", t.pid(), t.tid());
}
}
void dbg_internal(const char* fmt, va_list args) {
for (; *fmt != '\0'; fmt++) { for (; *fmt != '\0'; fmt++) {
if (*fmt != '%') { if (*fmt != '%') {
dbgputchar(*fmt); dbgputchar(*fmt);
@ -120,25 +128,34 @@ void dbgln_internal(const char* fmt, va_list args) {
} }
} }
} }
dbgputchar('\n');
} }
} // namespace } // namespace
void dbgln(const char* fmt, ...) { void dbg(const char* fmt, ...) {
va_list arg; va_list arg;
va_start(arg, fmt); va_start(arg, fmt);
dbgln_internal(fmt, arg); dbg_internal(fmt, arg);
va_end(arg); va_end(arg);
} }
void dbgln(const char* fmt, ...) {
AddProcPrefix();
va_list arg;
va_start(arg, fmt);
dbg_internal(fmt, arg);
va_end(arg);
dbgputchar('\n');
}
void panic(const char* fmt, ...) { void panic(const char* fmt, ...) {
asm volatile("cli"); asm volatile("cli");
AddProcPrefix();
va_list arg; va_list arg;
va_start(arg, fmt); va_start(arg, fmt);
dbgln_internal(fmt, arg); dbg_internal(fmt, arg);
va_end(arg); va_end(arg);
dbgln("PANIC"); dbgln("\nPANIC");
while (1) while (1)
; ;
} }

View File

@ -2,5 +2,6 @@
#include <stdarg.h> #include <stdarg.h>
void dbg(const char* fmt, ...);
void dbgln(const char* str, ...); void dbgln(const char* str, ...);
void panic(const char* str, ...); void panic(const char* str, ...);

View File

@ -41,14 +41,14 @@ Thread::Thread(Process& proc, uint64_t tid, uint64_t entry)
uint64_t Thread::pid() const { return process_.id(); } uint64_t Thread::pid() const { return process_.id(); }
void Thread::Init() { void Thread::Init() {
dbgln("[%u.%u] thread start.", pid(), id_); dbgln("Thread start.", pid(), id_);
uint64_t rsp = process_.vmm().AllocateUserStack(); uint64_t rsp = process_.vmm().AllocateUserStack();
SetRsp0(rsp0_start_); SetRsp0(rsp0_start_);
jump_user_space(rip_, rsp); jump_user_space(rip_, rsp);
} }
void Thread::Exit() { void Thread::Exit() {
dbgln("[%u.%u] Exiting", pid(), id_); dbgln("Exiting", pid(), id_);
state_ = FINISHED; state_ = FINISHED;
process_.CheckState(); process_.CheckState();
gScheduler->Yield(); gScheduler->Yield();

View File

@ -73,7 +73,7 @@ extern "C" uint64_t SyscallHandler(uint64_t call_id, char* message) {
panic("Returned from thread exit"); panic("Returned from thread exit");
break; break;
case Z_DEBUG_PRINT: case Z_DEBUG_PRINT:
dbgln("[%u.%u] [Debug] %s", thread.pid(), thread.tid(), message); dbgln("[Debug] %s", message);
break; break;
case Z_PROCESS_SPAWN: case Z_PROCESS_SPAWN:
return ProcessSpawn(reinterpret_cast<ZProcessSpawnReq*>(message)); return ProcessSpawn(reinterpret_cast<ZProcessSpawnReq*>(message));